kavi/kua-deploy
1
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity

fix: retire 'gal' HOSTNAME default → 'sol-prod' #12

Open
kavi wants to merge 1 commit from fix/hostname-gal-default into main
pull from: fix/hostname-gal-default
merge into: kavi:main
Conversation 0 Commits 1 Files changed 1 +1 -1
kavi commented 2026-07-15 05:41:11 +00:00
Owner
Copy link

Last hardcoded retired host in the engine source: server.js:101 const HOSTNAME = process.env.HOSTNAME || 'gal'.

Changed the fallback to 'sol-prod' (the engine's actual host). Inert — the deployed engine always sets HOSTNAME=sol-prod via compose/vault — but if it were ever unset, 'gal' would make isLocal() wrong and break deploys, whereas 'sol-prod' is correct.

Note: sol-prod, not sol-dev, for this one specifically — it's the engine's own execution host (used by isLocal(server)), so sol-dev here would re-break the exact isLocal bug just fixed. (App manifest gal→sol-dev mapping is separate.)

Completes the retired-host cleanup alongside PR #10 (ALLOWED_NODES, REGISTRY_SERVERS, port binding, fallbacks).

🤖 Generated with Claude Code

Last hardcoded retired host in the engine source: `server.js:101` `const HOSTNAME = process.env.HOSTNAME || 'gal'`. Changed the fallback to `'sol-prod'` (the engine's actual host). **Inert** — the deployed engine always sets `HOSTNAME=sol-prod` via compose/vault — but if it were ever unset, `'gal'` would make `isLocal()` wrong and break deploys, whereas `'sol-prod'` is correct. Note: `sol-prod`, not `sol-dev`, for this one specifically — it's the engine's own execution host (used by `isLocal(server)`), so `sol-dev` here would re-break the exact `isLocal` bug just fixed. (App *manifest* `gal`→`sol-dev` mapping is separate.) Completes the retired-host cleanup alongside PR #10 (ALLOWED_NODES, REGISTRY_SERVERS, port binding, fallbacks). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/hostname-gal-default:fix/hostname-gal-default
git switch fix/hostname-gal-default

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/hostname-gal-default
git switch fix/hostname-gal-default
git rebase main
git switch main
git merge --ff-only fix/hostname-gal-default
git switch fix/hostname-gal-default
git rebase main
git switch main
git merge --no-ff fix/hostname-gal-default
git switch main
git merge --squash fix/hostname-gal-default
git switch main
git merge --ff-only fix/hostname-gal-default
git switch main
git merge fix/hostname-gal-default
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kavi/kua-deploy!12
No description provided.